Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2ed16bce439d^
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e236c543b72f
Choose a head ref
  • 2 commits
  • 9 files changed
  • 1 contributor

Commits on Aug 10, 2017

  1. Copy the full SHA
    2ed16bc View commit details

Commits on Aug 11, 2017

  1. Remove BEQ.

    BEQ appeared to only get used by case/when statements where a
    when has a literal array as a first element. This meant that for
    when with a literal array, we were calling #== instead of #===.
    
    I could not reproduce this behavior in MRI, and the following
    code shows that we are doing something wrong.
    
    ```ruby
    class Array
      def ===(other)
        p :===
        self == other
      end
    end
    
    case x
    when []
    end
    ```
    
    MRI prints out :=== while JRuby does not.
    
    This logic apears to be from when we used to process whens with
    multiple arguments differently. Today, those cases get built as
    separate conditions, and I believe this removed code is no longer
    valid.
    headius committed Aug 11, 2017
    Copy the full SHA
    e236c54 View commit details
Loading