Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version updates: monit, movit, volatility, vigra #27947

Merged
merged 5 commits into from Aug 9, 2017
Merged

version updates: monit, movit, volatility, vigra #27947

merged 5 commits into from Aug 9, 2017

Conversation

WilliButz
Copy link
Member

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz force-pushed the master branch 2 times, most recently from 28bc590 to ac52700 Compare August 4, 2017 22:09
@NeQuissimus
Copy link
Member

Please check the Travis build, this seems to break mlt

@WilliButz
Copy link
Member Author

@NeQuissimus I rebased my fork with upstream master and built mlt without any issues. I also just started a nox-review locally.

@WilliButz
Copy link
Member Author

@NeQuissimus please correct me if I'm wrong: It looks to me like qt56.qtbase is the reason for the failing build[s]. For me (also for the hydra) tt's already failing to build on the current master.

@WilliButz
Copy link
Member Author

In this case these updates should probably be put on hold until qt is fixed :)

@globin globin self-assigned this Aug 9, 2017
@WilliButz WilliButz requested a review from FRidh as a code owner August 9, 2017 19:48
@globin globin merged commit e9a2cfd into NixOS:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@globin globin

Labels
8.has: package (update) 9.needs: reporter feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @NeQuissimus @globin