Fix gogs service in the absence of any passwords #27950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…service definition is set
jgertm
force-pushed
the
jgertm/gogs-no-passwd
branch
from
21abc89
to
2745c0d
Compare
NeQuissimus
approved these changes
Aug 5, 2017
|
cc @schneefux for testing. |
|
ping |
rvl
added a commit
to rvl/nixpkgs
that referenced
this pull request
Sep 13, 2017
If neither database.password or database.passwordFile were provided, it would try and fail to coerce null to a string. This fixes the situation where there is no password for the database. Resolves NixOS#27950
|
@fpletz I have pushed the commit b5dedfa to fix this. Could you please merge to master and 17.09?. |
8 tasks
|
Closing in deference to #29468 |
fpletz
pushed a commit
that referenced
this pull request
Sep 17, 2017
If neither database.password or database.passwordFile were provided, it would try and fail to coerce null to a string. This fixes the situation where there is no password for the database. Resolves #27950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Gogs wasn't working for me when configured without any passwords.
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)