Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freerdp: 20170502 -> 20170724 #27872

Merged
merged 1 commit into from
Aug 27, 2017
Merged

freerdp: 20170502 -> 20170724 #27872

merged 1 commit into from
Aug 27, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 2, 2017

Fixes multiple security issues:

See http://www.freerdp.com/2017/07/24/freerdp-security for announcement.

This will also have to be backported to release-17.03 I think.

Motivation for this change
Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Fixes multiple security issues:
 * TALOS-2017-0336 CVE-2017-2834
 * TALOS-2017-0337 CVE-2017-2834
 * TALOS-2017-0338 CVE-2017-2836
 * TALOS-2017-0339 CVE-2017-2837
 * TALOS-2017-0340 CVE-2017-2838
 * TALOS-2017-0341 CVE-2017-2839

See http://www.freerdp.com/2017/07/24/freerdp-security for announcement.
@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peterhoeg, @shlevy and @volth to be potential reviewers.

@@ -14,13 +14,13 @@

stdenv.mkDerivation rec {
name = "freerdp-git-${version}";
version = "20170502";
version = "20170724";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about changing to 2.0.0-rc0?

@joachifm
Copy link
Contributor

@lsix is this ready?

@fpletz fpletz merged commit 310e2d6 into NixOS:master Aug 27, 2017
@lsix lsix deleted the update_freerdp branch August 22, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants