utils: Disambiguate between normal and malformed EOF in nix::readLine. #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going back through my old PRs....I guess this is still probably a good idea? |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Ericson2314
force-pushed
the
utils-clarity
branch
from
a4b85ab
to
20671dd
Compare
Ericson2314
commented
Apr 19, 2022
| if (s == "") | ||
| return std::nullopt; | ||
| else | ||
| throw EndOfFile("unexpected end-of-file while reading line"); |
There was a problem hiding this comment.
end-of-file is usually used in error messages, rather than EOF.
|
I rebased this, and split the function to make the intent clearer. |
fricklerhandwerk
added
language
|
@Ericson2314 do you have an example of “normal” and “malformed” EOFs? Not sure what the distinction means |
|
All mark this draft until I have a test. It is a very old PR :). The issue was a lack of a trailing newline I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This little change was extracted from my old version of #1480. I figure it is good the user to get a better error message, and at some later point we can also use
optionaland clean up use sites.WIP still need to build/test.