stdenv/setup.sh: undo local -n change
#27618
Conversation
It's better than the eval solution this is adding back, but until we can rely on a particular version of bash in nix-shell, this just breaks too much stuff. See NixOS/nix@c94f3d5 and NixOS/nix#1483 for the better long-term solution.
|
Cool, I'm inclined to stick to the tried and tested until the storm passes 😄 but if you can make sure it works on CentOS and macOS, I'm happy either way. I'm running a macOS and CentOS build right now. |
|
@copumpkin Yeah, since this is straight-to-master, it makes complete sense to be conservative. In my earlier reversion PR for |
As @oxij points out in [1], this breakage is especially serious because it changes the contents of built environments without a corresonding change in their hashes. Also, the revert is easier than I thought. This reverts commit 3cb745d. [1]: #27427 (comment)
|
Okay, CentOS and macOS both work with this PR merged. |
|
I'm going to merge this and cancel the rest of the master builds. Should get us a channel update in ~1 day |
|
@copumpkin @Ericson2314 can you merge master back into staging. The current staging builds are pretty useless and best be halted. |
|
I started working on that. But staging was completely broken on Darwin (couldn't even build stdenv, so not my changes). |
|
@copumpkin @Ericson2314 how come Darwin is broken on staging and who is fixing this? Not having these changes in staging blocks staging and thereby us from merging any other mass-rebuilds. edit: so that's #27650 |
local -nis theoretically better than the eval solution this is adding back, but until we can rely on a particular version of bash in nix-shell, this just breaks too much stuff.See NixOS/nix@c94f3d5 and NixOS/nix#1483 for the better long-term solution.
Motivation for this change
macOS and CentOS (among probably others) have
nix-shellbroken by default right now. Untilnixpkgs-unstablegets rid oflocal -n, this will cause (and is causing) a ton of pain. I'm doing this directly against master because I want to get a successful Hydra build to bumpnixpkgs-unstableback to a good state ASAP.We'll also need to do this to other
local -ninstances on staging