Replace boost::atomic with std::atomic (where possible) #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Jul 25, 2017
| macro(hpx_check_for_cxx11_std_atomic) | ||
| add_hpx_config_test(HPX_WITH_CXX11_ATOMIC | ||
| SOURCE cmake/tests/cxx11_std_atomic.cpp | ||
| LIBRARIES "-latomic" |
There was a problem hiding this comment.
Doesn't this get in the way on platforms not supporting libatomic?
There was a problem hiding this comment.
It somehow doesn't, but I don't really understand why that is the case.
There was a problem hiding this comment.
I guess it is fine as long as the compiler only warns for unknown arguments and doesn't fail if it can't find the library to link against.
Naios
added a commit
to Naios/hpx
that referenced
this pull request
Jul 25, 2017
Naios
added a commit
to Naios/hpx
that referenced
this pull request
Jul 27, 2017
K-ballo
force-pushed
the
std-atomic-lite
branch
2 times, most recently
from
baf4deb
to
f92abdc
Compare
K-ballo
force-pushed
the
std-atomic-lite
branch
3 times, most recently
from
7e1e084
to
7a1ff1a
Compare
|
@K-ballo should we go ahead and merge this - or are you looking for a solution to the |
K-ballo
force-pushed
the
std-atomic-lite
branch
from
7a1ff1a
to
a08615a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.