LGTM

To be frank, I don't recall exactly why it is loaded in both places. I feel this may have been from some info from @cleverca22.

cc @domenkozar

The exact details are very arbitrary and complex, but in short .profile is only for interactive login shells, and .bashrc only for interactive non-login shells. While its commonplace for one to source the other, and interactive non-login shells to be ultimately forked from interactive login shells, these are technically orthogonal.

I have no idea what the best route is.

@Ericson2314 yes, but bashrc will get loaded in both cases because /etc/profile has this:

if [ "${BASH-no}" != "no" ]; then
        [ -r /etc/bashrc ] && . /etc/bashrc
fi

@edolstra would you like to merge this?

Dunno, this seems dangerous to me because it can lead to NIX_PATH growing on every shell invocation.

@LnL7 This is on macOS or NixOS, or something else. I've seen such things but have no idea where that comes from / what convention it is?

@edolstra We could only conditionally append, to be idempotent.

I guess the main issue here is that this is loaded in multiple places, /etc/profile unexpectedly loads this a second time after /etc/bashrc is finished getting rid of any changes that happened there.

@Ericson2314 This is only used on macOS AFAIK.

@LnL7 This file also clobbers NIX_PROFILES which will also mess up nix-darwin IIUC

Closing in favour of #1774