Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluma: init at 1.18.2 #27984

Merged
merged 3 commits into from
Aug 12, 2017
Merged

pluma: init at 1.18.2 #27984

merged 3 commits into from
Aug 12, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Aug 6, 2017

Motivation for this change

Add Pluma package.

Pluma is a powerful text editor for MATE.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @clemensmanert and @armijnhemel to be potential reviewers.

@infinisil
Copy link
Member

infinisil commented Aug 7, 2017

I'm noticing that almost all packages in pkgs/desktops/mate are using the same source, "http://pub.mate-desktop.org/releases/${major-ver}/${name}.tar.xz", but there are currently 4 different (major, minor) versions being used (atril-1.19.0, caja-1.18.0, mate-common-1.18.0, mate-desktop-1.18.0, mate-icon-theme-faenza-1.18.0, mate-icon-theme-1.18.1, mate-terminal-1.18.0, pluma-1.18.2).

I think it would make sense to refactor it so that a single version is used for all the packages distributed by this Mate source to minimize the dependencies.

@romildo
Copy link
Contributor Author

romildo commented Aug 7, 2017

1.19.x seems to be development versions. Only atril is using it. It has been added by someone else. The other packages are at 1.18.x, which is the stable version. Some of them receive minor updates. Therefore the minor version x is not the same for all of them.

So I agree to use the same major stable versions for the mate packages, with the latest minor version available for each of them. Therefore atril would be downgraded to version 1.18.0.

I want to (slowly) add more mate applications until the desktop is complete.

@infinisil
Copy link
Member

Oh I actual misread the download URL, I thought all packages were built from the same source tarball, which is not the case, sorry for that.

In that case it's not really bad with the versions, probably just updating them to v1.19 when it's out would be nice.

I tested the editor btw, works without problems (except some GTK messages on stdout regarding themes, but I think that's pretty standard to have).

@Mic92 Mic92 merged commit 872f0bc into NixOS:master Aug 12, 2017
@romildo romildo deleted the new.pluma branch August 12, 2017 09:08
@romildo
Copy link
Contributor Author

romildo commented Aug 12, 2017

@Mic92 Why a dependency on gnome3.defaultIconTheme is needed?

Should every application with icons depend on it?

Also when should gnome3.defaultIconTheme be prefferred over hicolor_icon_theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants