Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-43: Fix incorrect output from generate_selection #27

Merged
merged 5 commits into from Aug 7, 2017
Merged

SOLR-43: Fix incorrect output from generate_selection #27

merged 5 commits into from Aug 7, 2017

Conversation

gentlecat
Copy link
Contributor

No description provided.

@gentlecat gentlecat changed the title Fix incorrect output from generate_selection SOLR-43: Fix incorrect output from generate_selection Aug 6, 2017
@gentlecat gentlecat changed the title SOLR-43: Fix incorrect output from generate_selection [WIP] SOLR-43: Fix incorrect output from generate_selection Aug 6, 2017
The current `pk` selection didn't work because it wasn't the primary key
from the remote table, it was from the table for `current_model`.
This removes an unnecessary inner query in some cases, but may need to
be reverted if it has unintended effects elsewhere.
@gentlecat gentlecat changed the title [WIP] SOLR-43: Fix incorrect output from generate_selection SOLR-43: Fix incorrect output from generate_selection Aug 7, 2017
@gentlecat
Copy link
Contributor Author

gentlecat commented Aug 7, 2017

@mwiencek, thanks a lot! I'm not seeing the same issue anymore. Let's see what else is broken. :)

@gentlecat gentlecat merged commit 5b79b5d into metabrainz:master Aug 7, 2017
@gentlecat gentlecat deleted the selection-fix branch August 7, 2017 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants