Fix FreeBSD 11 #2802
Merged
Fix FreeBSD 11 #2802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD libc.so.7 doesn't define `environ` when building a shared library. Due to disallowing undefined symbols with `-z,defs` this prevents `libhpx.so` from building. We introduce a new variable `freebsd_environ` that gets initialized during HPX startup which is used by any part of the system that previously used the `environ` variable directly.
FreeBSD 11.0 removes the `MAP_NORESERVE` parameter to mmap. It has previously not been implemented in the OS and as such, removing the flag has no side effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a workaround for an unavailable
environin shared libraries by initializing afreebsd_environin HPX startup for use in the runtime system.We also remove
MAP_NORESERVEfrommmapcode for FreeBSD, as the parameter previously was unimplemented and now is completely removed from FreeBSD 11.0.