Fix Darwin stdenv to work on 10.13 (backport to 17.03) #27630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main changes are in libSystem, which lost the coretls component in 10.13 and some hardening changes that quietly crash any program that uses %n in a non-constant format string, so we've needed to patch a lot of programs that use gnulib. (cherry picked from commit 0419452)
copumpkin
added
1.severity: mass-darwin-rebuild
1.severity: mass-rebuild
6.topic: darwin
|
I suggest we merge this, wait for Nix maintenance branch to build and test before next Nix release. |
LnL7
approved these changes
Jul 25, 2017
grahamc
approved these changes
Jul 26, 2017
|
This is probably safe to merge now that most of trunk has built. |
|
We might also have to backport the bootstrap fix. |
|
Good point. That seems like a separate PR though |
|
Yeah, that's fine. |
|
This causes a build failure on older OS X: |
|
I think that's fixed by the bootstrap tools I was referring to #27645 |
|
Note that this has been a disaster on Hydra, due to libc++abi failing to build: https://hydra.nixos.org/eval/1378816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are in libSystem, which lost the coretls component in 10.13 and some hardening changes that quietly crash any program that uses %n in a non-constant format string, so we've needed to patch a lot of programs that use gnulib.
This was tested fairly significantly before the cherry-pick but I haven't done much or solicited much testing for this version against 17.03. Testing welcome!
(cherry picked from commit 0419452)
Motivation for this change
Nix (the tool) builds against 17.03 so if we want to get a Nix build and installer that works on 10.13 and that isn't built and hosted by me, we need to get this change backported to 17.03 😄
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)