add libcurl to radarr + sonarr wrappers #27628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Jul 25, 2017
pkgs/servers/radarr/default.nix
Outdated
| @@ -17,6 +17,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| makeWrapper "${mono}/bin/mono" $out/bin/Radarr \ | |||
| --add-flags "$out/share/${name}/Radarr.exe" \ | |||
| --prefix LD_LIBRARY_PATH ':' "${curl.out}/lib" \ | |||
There was a problem hiding this comment.
Not a blocker, but you could take the opportunity to combine these into a single makeLibraryPath [ curl sqlite ... ] here. Briefer and obviates the need to worry about output selection.
There was a problem hiding this comment.
Thanks- didn't know about makeLibraryPath, have updated.
georgewhewell
force-pushed
the
add-libcurl-to-sonarr-radarr-wrapper
branch
from
db6a339
to
f993db0
Compare
georgewhewell
force-pushed
the
add-libcurl-to-sonarr-radarr-wrapper
branch
from
f993db0
to
a3369f3
Compare
|
cc @edwtjo |
fadenb
approved these changes
Jul 29, 2017
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Mono 4 doesn't support TLS 1.2, so breaks on many https:// urls. Adding libcurl lets sonarr/radarr fallback work.
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)