Listing shortcode #2880
Merged
Listing shortcode #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Jul 26, 2017
nikola/plugins/shortcode/listing.py
Outdated
| @@ -0,0 +1,58 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # This file is public domain according to its author, Brian Hsu | |||
There was a problem hiding this comment.
Whoa, flashback. I don't think any of that code is still there. OTOH, I suspect this is because I copied gist.py :-)
|
Could we avoid duplicating rest/listings.py code? |
|
@Kwpolska there is not that much repeated code:
It's about 10 LOC and only used in these two, so can't go to utils/ ... any suggestions where I could put it? |
Kwpolska
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #2868