Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash: cleanup unused file #28355

Merged
merged 1 commit into from Aug 18, 2017
Merged

bash: cleanup unused file #28355

merged 1 commit into from Aug 18, 2017

Conversation

vanschelven
Copy link
Contributor

Motivation for this change

The only usage location was removed in f803270
Grepping for bash-4.3 yields no results

Things done

Most of the below do not apply, as the file is completely unused.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vanschelven
bash: cleanup unused file
d92a451 
The only usage location was removed in f803270
Grepping for bash-4.3 yields no results
@dezgeg dezgeg merged commit 3c65062 into NixOS:master Aug 18, 2017
@vanschelven vanschelven deleted the bash-4.3-cleanup branch August 19, 2017 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanschelven @dezgeg