Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsync service: allow running as user (plus some tweaks) #27993

Merged
merged 3 commits into from Aug 11, 2017
Merged

rsync service: allow running as user (plus some tweaks) #27993

merged 3 commits into from Aug 11, 2017

Conversation

Nadrieril
Copy link
Member

It is useful to be able to run rsync as a non-root user.
I also cleaned a bit the config file generation.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Nadrieril, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ehmry and @shlevy to be potential reviewers.

@Nadrieril Nadrieril changed the title rsync service: allow running as user plus some tweaks rsync service: allow running as user (plus some tweaks) Aug 6, 2017
@fpletz fpletz added this to the 17.09 milestone Aug 11, 2017
fpletz
fpletz approved these changes Aug 11, 2017
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! Thanks!

@fpletz fpletz merged commit 9917450 into NixOS:master Aug 11, 2017
@Nadrieril Nadrieril deleted the rsync-run-as-user branch February 10, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update)
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Nadrieril @mention-bot @fpletz