Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: 0.8.9 -> 0.9.4 #27989

Merged
merged 1 commit into from
Aug 7, 2017
Merged

jsonnet: 0.8.9 -> 0.9.4 #27989

merged 1 commit into from
Aug 7, 2017

Conversation

benley
Copy link
Member

@benley benley commented Aug 6, 2017

Motivation for this change

New upstream version

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@benley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @copumpkin and @pSub to be potential reviewers.

@benley
Copy link
Member Author

benley commented Aug 6, 2017

Argh, apparently this breaks python3Packages.jsonnet
but not jsonnet or pythonPackages.jsonnet

@benley
Copy link
Member Author

benley commented Aug 6, 2017

Nevermind - python3Packages.jsonnet was already broken. The _jsonnet.c wrapper needs to be updated for python 3 compatibility upstream.

@benley
Copy link
Member Author

benley commented Aug 7, 2017

I'm fixing python 3 support upstream in google/jsonnet#335 :-)

@benley benley merged commit 989514f into NixOS:master Aug 7, 2017
@benley benley deleted the jsonnet-0.9.4 branch August 7, 2017 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants