exhibitor: Fix bug with automatic instance management #27700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copumpkin
reviewed
Jul 28, 2017
| ${cfg.extraConf} | ||
| ''; | ||
| # NB: toString rather than lib.boolToString on cfg.autoManageInstances is intended. | ||
| # Exhibitor expects it to be a 0/1 integer rather than a truthy/falsey string |
There was a problem hiding this comment.
Given that toString returns "1" or "", this might strike folks as weird. I think the actual Exhibitor logic checks against "1" so toString is fine, but it might be clearer if the comment said it's okay because of that. Or just be explicit with if foo then "1" else "0" 😄
There was a problem hiding this comment.
Updated the comment and verified that toString does what I expect. Also rebased against latest master.
Exhibitor tests the auto-manage-instances config value to see if it's a non-zero integer, rather than a true/false string, which was getting put into the config before. This now causes autoManageInstances to behave correctly.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exhibitor expects the auto-manage-instances config value to be an
integer of 0 or 1, rather than a true/false string, which was getting
printed before.
Motivation for this change
Current NixOS module has a bug that prevents automatic instance management from working properly.
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)/cc @copumpkin