Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snowman: init at 2017-07-22 #27641

Merged
merged 1 commit into from Aug 30, 2017
Merged

snowman: init at 2017-07-22 #27641

merged 1 commit into from Aug 30, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 25, 2017

Motivation for this change
Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 25, 2017

Haven't tried using with IDA. Documentation says Qt version needs to match your IDA's Qt, so include both qt4 and qt5 variants as basic coverage.

@dtzWill
Copy link
Member Author

dtzWill commented Jul 25, 2017

Not sure how to include these (cc #27604) but created a derivation for running the "snowman-tests" test suite to check the build Snowman:

Commit
Branch

If nothing else they're available in case anyone is interested :). LMK if it makes sense to include those in this PR otherwise I'll wait on discussion in #27604.

@Profpatsch
Copy link
Member

Profpatsch commented Aug 1, 2017

Not sure how to include these (cc #27604)

Awesome!

Basically you have a withTests :: AttrsOf Derivation -> Derivation -> Derivation which takes an attrset of tests (name to derivation to run) and the actual derivation and outputs a derivation that depends on all tests to build.
If you do something like

{ pkgs, lib}:
let
  # stub, FIXME(Profpatsch)
  withTests = flip lib.const;

  snowman =;

  tests = {
    snowman-testsuite = pkgs.callPackage ./tests.nix { inherit snowman; };
  };

in withTests tests snowman

I will pick it up once the tests get merged.

@Profpatsch Profpatsch mentioned this pull request Aug 1, 2017
@fpletz fpletz merged commit 5543e99 into NixOS:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants