Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbol visibility such that carbons with a charge are always shown. #350

Merged
merged 1 commit into from Jul 26, 2017

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Jul 25, 2017

Noel put in a dodgey SMILES and found a corner case I forgot to handle. The rule of thumb for showing a carbon in a depicition is if the valence isn't 4, or if it's colinear. In this central atom is a 4 valent carbon with a charge and so wasn't being displayed.

C=[CH-]C

@egonw egonw merged commit e8d1777 into master Jul 26, 2017
@johnmay johnmay deleted the patch/symbol_vis branch January 30, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants