Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: 2.29 -> 2.31 #27642

Merged
merged 1 commit into from Aug 20, 2017
Merged

chromedriver: 2.29 -> 2.31 #27642

merged 1 commit into from Aug 20, 2017

Conversation

mkreidenweis
Copy link

@mkreidenweis mkreidenweis commented Jul 25, 2017 •
edited

Motivation for this change

Update chromedriver

Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 27, 2017

cc @cillianderoiste

@joachifm joachifm merged commit 8608d32 into NixOS:master Aug 20, 2017
@mkreidenweis mkreidenweis deleted the update-chromedriver-to-2.31 branch August 21, 2017 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkreidenweis @FRidh @joachifm @Janik-Haag