Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firejail: 0.9.44.10 -> 0.9.48 #27639

Merged
merged 1 commit into from Jul 28, 2017
Merged

Conversation

jfrankenau
Copy link
Member

@jfrankenau jfrankenau commented Jul 25, 2017

Motivation for this change

Update and fix #24542 and netblue30/firejail#1098: When a Firejail profile uses a whitelist it is necessary to whitelist ~/.nix-profile as well. However because ~/.nix-profile is a symlink to the Nix store which is owned by root, by default Firejail does not read it. In Firejail version 0.9.46 the option follow-symlink-as-user was introduced to address this problem.

Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @lheckemann @tilpner @tex @r-raymond @7c6f434c

@joachifm joachifm merged commit c36a68e into NixOS:master Jul 28, 2017
@jfrankenau jfrankenau deleted the update-firejail branch August 18, 2017 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firejail: Error: cannot establish communication with the parent, exiting...
2 participants