-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
pythonPackages.cryptop: init at 0.1.0 #27778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Python applications do not belong in python-packages.nix
. Please move the expression out of python-modules
and call it from all-packages.nix
instead. Otherwise, this looks good.
Thanks Fridh! I saw that comment In the python contributing guide, but wasn't sure where to put it instead of I'm also struggling a little to test this. The nox command seems to be dying after trying to build some unrelated Haskell packages in my personal
|
d63cfbb
to
9c95417
Compare
Hmm I seem to have busted it. I'll keep trying to figure it out; is there a good representative Python application I should study for reference? Most of the ones I'm looking at (youtube-dl, yapf, isort, flake8, etc.) seem to be in |
This commit adds the python application cryptop, which is a small curses application for viewing cryptocurrency portfolio values.
5dbbe61
to
031d627
Compare
@bhipple good that you gave it a try. Unfortunately you've seen some bad examples so I've forced push the necessary changes instead. |
Do you know how I could test this with
but this one complains about undefined cryptop string:
Any hints? |
Thanks for the help Fridh. Now I can study your fix as the "canonical" example 👍 |
Answer to the above question in case someone looks at it, courtesy of clever in IRC:
|
This commit adds the python application cryptop, which is a small curses
application for viewing cryptocurrency portfolio values.
Motivation for this change
New application.
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)