Skip to content

Python wrapper: undo change package accumulators #27761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2017
Merged

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jul 30, 2017

because we would otherwise end up with broken wrappers because PATH and
PTYHONPATH weren't set.

Partially reverts 8d76eff.

cc @Ericson2314

because we would otherwise end up with broken wrappers because PATH and
PTYHONPATH weren't set.
@FRidh FRidh added 0.kind: regression Something that worked before working no longer 1.severity: mass-rebuild This PR causes a large number of packages to rebuild 6.topic: python labels Jul 30, 2017
@mention-bot
Copy link

@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @adnelson, @chaoflow and @FRidh to be potential reviewers.

@FRidh FRidh changed the title Python wrapper: undo change 8d76effc178747f0c8f456fe619c1b014736a6af Python wrapper: undo change package accumulators Jul 30, 2017
@FRidh FRidh merged commit 6128dd4 into NixOS:staging Jul 30, 2017
@FRidh
Copy link
Member Author

FRidh commented Jul 30, 2017

I've pushed this to staging.

@Ericson2314
Copy link
Member

Oh wow, I meant to do [ -z ] or &&. Sorry for the breakage / I hope this is the last of it.

@FRidh FRidh deleted the prop branch October 20, 2017 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: regression Something that worked before working no longer 1.severity: mass-rebuild This PR causes a large number of packages to rebuild 6.topic: python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants