Make buildEnv overridable #27780
Merged
Make buildEnv overridable #27780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilpner
force-pushed
the
overridable-buildenv
branch
3 times, most recently
from
e859d90
to
05331be
Compare
|
Should buildFHSUserEnv be overridable too? |
tilpner
force-pushed
the
overridable-buildenv
branch
2 times, most recently
from
eece066
to
d01d1ae
Compare
|
It would be cleaner to put |
|
Yes
|
tilpner
force-pushed
the
overridable-buildenv
branch
3 times, most recently
from
94f8650
to
4da5bf2
Compare
callPackage already calls makeOverridable, but that just makes the function that evaluates to buildEnv overridable, not buildEnv itself. If no overridable version of buildEnv is used during construction, users can't override e.g. `paths` at all
tilpner
force-pushed
the
overridable-buildenv
branch
from
4da5bf2
to
77f1c7d
Compare
|
This is good to go, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
callPackage already calls makeOverridable, but that just
makes the function that evaluates to buildEnv overridable,
not buildEnv itself.
If no overridable version of buildEnv is used during construction,
users can't override e.g.
pathsat allThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)