Skip to content

Replace Unicode quotes in user-facing strings by ASCII #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2017
Merged

Replace Unicode quotes in user-facing strings by ASCII #1495

merged 1 commit into from
Jul 31, 2017
+662 −662

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 30, 2017 •
edited
Loading

Relevant RFC: NixOS/rfcs#4

$ ag -l | xargs sed -i -e "/\"/s/’/'/g;/\"/s/‘/'/g"

deprecates #1377

@Mic92
Replace Unicode quotes in user-facing strings by ASCII
2fd8f8b 
Relevant RFC: NixOS/rfcs#4

$ ag -l | xargs sed -i -e "/\"/s/’/'/g;/\"/s/‘/'/g"
@edolstra edolstra merged commit 2fd8f8b into NixOS:master Jul 31, 2017
@edolstra
Copy link
Member

Thanks!

@edolstra edolstra mentioned this pull request Jul 31, 2017
Closed
@Mic92
Copy link
Member Author

Mic92 commented Jul 31, 2017

I will replace this in the documentation. But I have not done this in this pull request as I wanted to have an automatic way to convert the code in case of merge conflicts.

@Mic92 Mic92 deleted the quotes branch July 31, 2017 12:53
@Mic92 Mic92 mentioned this pull request Jul 31, 2017
Merged
@arcuru arcuru mentioned this pull request Feb 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @edolstra