setroot: 1.4.4 -> 2.0.1 #27564
Merged
setroot: 1.4.4 -> 2.0.1 #27564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vyp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @noctuid and @matthewbauer to be potential reviewers. |
Mic92
reviewed
Jul 23, 2017
pkgs/tools/X11/setroot/default.nix
Outdated
| @@ -5,14 +5,14 @@ | |||
| assert enableXinerama -> libXinerama != null; | |||
|
|
|||
| stdenv.mkDerivation rec { | |||
| version = "1.4.4"; | |||
| version = "2017-01-24"; | |||
There was a problem hiding this comment.
Is there a reason not to upgrade to 2.0 instead?
There was a problem hiding this comment.
Yes sorry should have mentioned that, forgot. Because the latest commit contains a bug fix. And it was commited nearly a year after v2.0 so it's unlikely there's going to be another new release soon, otherwise I would have just gone with v2.0.
There was a problem hiding this comment.
Updated to point to latest v2.0.1 tag. :)
Mic92
referenced
this pull request
in ttzhou/setroot
Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)