Make sdl samples work on Linux #4734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jul 22, 2017
|
If this doesn't break OSX than I see no reason not to merge it. |
|
@RX14 yes, I kept the OSX part untouched |
|
Allright. I never had a failure, but I don't call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add temporally fix to sdl samples, because these samples don't work currently.
I say temporally because it was discused multiples times before #3678 #381 #388 #387
Also I think if this change make that sdl samples works again on Linux, Ain't better a working sample that a failing sample?
Currently on master:
With this PR: