Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more Vulnix dependencies from pythonPackages #27556

Closed
wants to merge 6 commits into from
Closed

Use more Vulnix dependencies from pythonPackages #27556

wants to merge 6 commits into from

Conversation

adisbladis
Copy link
Member

Motivation for this change

Moving a lot of Vulnix dependencies to depend on pythonPackages instead of it's own pinned ones.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@adisbladis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @plumps, @Mic92, @domenkozar and @FRidh to be potential reviewers.

This was referenced Jul 22, 2017
Closed
Merged
@FRidh
Copy link
Member

FRidh commented Jul 22, 2017

What is the reason for this? You do realize that pythonPackages may update to newer, and again incompatible, versions?

@FRidh FRidh self-assigned this Jul 23, 2017
@Mic92
Copy link
Member

Mic92 commented Jul 23, 2017

The reason that was not done in the first place, was just laziness. The package duplication also have problems. For instance if we apply fixes to pythonPackages, we also need to copy them to vulnix's packages too.

@adisbladis
Copy link
Member Author

@FRidh Something changed and some build-time only deps (manuel, transaction) for BTrees and zconfig were suddenly not pulled in.

I figured it was better to fix these issues in pythonPackages and then use these in the vulnix package so any future fixes only require changes in one spot.

@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

This is in staging now.

@FRidh FRidh closed this Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @mention-bot @FRidh @Mic92