iosevka: Build from source #27573
Closed
iosevka: Build from source #27573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfrankenau, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ericsagnes, @zimbatm and @cstrahan to be potential reviewers. |
|
Merge conflict here |
jfrankenau
force-pushed
the
build-iosevka
branch
from
0697751
to
4e45107
Compare
|
The package no longer builds because Iosevka requires nodejs-8_x, but node2nix doesn't support it. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Iosevka font is fully described by code and thus it is possible to build it from source instead of using the provided binaries. This for example allows us to inject patches into the build process to alter the font's appearance.
To satisfy the build dependencies I've added
otfccto the packages. Other than that Iosevka's build process relies on Node packages which are fetched usingnode2nix.Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)cc @cstrahan