Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WRITE_EXTERNAL_STORAGE default permission #1081

Closed
inclement opened this issue Jul 22, 2017 · 11 comments
Closed

Remove WRITE_EXTERNAL_STORAGE default permission #1081

inclement opened this issue Jul 22, 2017 · 11 comments

Comments

@inclement
Copy link
Member

This may need a small change in Kivy, but is otherwise non-essential.

@KeyWeeUsr
Copy link
Contributor

KeyWeeUsr commented Jul 22, 2017

It's forced here, it's needed for kivy/kivy#4777 and fixed in the linked PR. It's an api break though.

@inclement
Copy link
Member Author

Oh, great, I hadn't seen that PR. I was going to propose also checking the old location first, but otherwise defaulting to the new (better) one. I think that would be worthwhile to fix this annoying problem on Android, even if it's slightly more complex.

We could also use the app's official external storage directory, found by querying the Android API. That would be more consistent with the spirit of the current behaviour.

@KeyWeeUsr
Copy link
Contributor

I was thinking about it, but then it'd mean including at least pyjnius to each android application, which isn't the happiest solution. We could maybe use the old-ish android package/recipe, but that might still need some editing and also requiring from user to include it (or add it to kivy as a requirement).

If we can't do any of these cases, we end up with an environment variable. As that thing is set in(/for) start.c, we can use sys.executable

@inclement
Copy link
Member Author

pyjnius is already a Kivy dependency on Android.

@KeyWeeUsr
Copy link
Contributor

That kind of skipped my mind completely 😄

@fyookball
Copy link

I am having a problem and I don't know whether it is related to this issue, but I just built an apk for my project, which gives a parsing error (can't install)...but it works fine if i manually copy the apk file to the phone with a usb cable. Is there something I can do to force my android phone to properly download the apk?

@inclement
Copy link
Member Author

@fyookball There is no reason to think that this issue is related to your problem. Please post instead on the kivy-users mailing list.

@ghost
Copy link

ghost commented Aug 24, 2018

Is there a switch to remove this permission for non-kivy projects that use python-for-android?

@inclement
Copy link
Member Author

No, there isn't. Philosophically I'd prefer to just fix Kivy and then remove the default permission entirely, but it would be fair enough to add a toggle for it as it stands.

@ghost
Copy link

ghost commented Jan 26, 2019

Okay, once the SDL2 version bump is in, this should be relatively simple to do. I'll look into it, I need to add another option I want to AndroidManifest.xml anyway (the one that makes the whole app window shrink/downsize to make room for an opening virtual keyboard, rather than get overlapped by it)

@ghost
Copy link

ghost commented Jul 28, 2019

I think with Android 5+ versions this is obsolete anyway, right? Which is all we support as minimum, since there runtime permissions requests are needed anyway. I think therefore it makes sense to close this ticket, anyone feel free to poke me if this is wrong and I'll gladly reopen!

@ghost ghost closed this as completed Jul 28, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants