Correct nilable variable type inference after exception handler #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed crystal-lang#4723 Old implementation loses variable's `nil_if_read` flag after exception handler, so scope variables (i.e. meta vars) type inference is broken when reading such a variable after exception handler.
RX14
approved these changes
Jul 22, 2017
RX14
added
kind:bug
topic:compiler
topic:lang:type-system
and removed
topic:compiler
labels
makenowjust
changed the title
|
Perfect! |
makenowjust
deleted the
fix/crystal/4723-keep-nil-if-read-around-exception-handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #4723
Old implementation loses variable's
nil_if_readflag after exception handler, so scope variables (i.e. meta vars) type inference is broken when reading such a variable after exception handler.To need more information, see these comments in spec. Thank you.