spotify: 1.0.57.474.gca9c9538-30 -> 1.0.49.125.g72ee7853-111 (downgrade) #27563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srhb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rickynils, @aske and @edolstra to be potential reviewers. |
Mic92
reviewed
Jul 23, 2017
| @@ -8,7 +8,7 @@ let | |||
| # Please update the stable branch! | |||
| # Latest version number can be found at: | |||
| # http://repository-origin.spotify.com/pool/non-free/s/spotify-client/ | |||
There was a problem hiding this comment.
Can you also add a warning to not use the beta versions found there. I think the least upgrade was accidentally because it is non-obvious, that this directory also contain testing releases as well.
There was a problem hiding this comment.
Good point, I've made it a bit clearer.
clarify note about stable and testing versions
|
Thanks! |
|
I guess this should be also backported to |
|
Yes, otherwise Spotify will not be installable. Do I need to do anything in this regard? |
|
done in e982b64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The current spotify version has been removed from upstream. The new (testing) version segfaults (#27560) rendering it unusable. The build implies that we were once following the stable releases. This commit makes us do that once more.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)