Skip to content

noXlibs: enrich package overrides #27567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2017
Merged

noXlibs: enrich package overrides #27567

merged 1 commit into from
Jul 26, 2017

Conversation

k0ral
Copy link
Contributor

@k0ral k0ral commented Jul 22, 2017

Motivation for this change

When working on a headless server, it is convenient to disable installation of graphical frontends via a single configuration setting. I've only found noXlibs to do that, so I've enriched it with a bunch of package overrides.
Note that it may not be a good idea to have noXlibs depend on app derivations. Maybe a better way is to invert the dependency: feed a noXlibs flag to app derivations so that they can decide what to disable.

Things done

Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@k0ral, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @7c6f434c and @bluescreen303 to be potential reviewers.

@fpletz fpletz added this to the 17.09 milestone Jul 26, 2017
@fpletz fpletz merged commit a3e6df6 into NixOS:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants