Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: f6817ddf99e3
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: cd3d8529433f
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 3, 2017

  1. dockerTools: fix image json and manifest 

    The image json is not exactly the same as the layer json, therefore I
changed the implementation to use the `baseJson` which doesn’t include
layer specific details like `id`, `size` or the checksum of the layer.

Also the `history` entry was missing in the image json. I’m not totally
sure if this field is required, but a I got an error from a docker
registry when I’ve tried to receive the distribution manifest of an
image without those `history` entry:

GET: `http://<registry-host>/v2/<imageName>/manifests/<imageTag>`

```json
{
  "errors": [
    {
      "code": "MANIFEST_INVALID",
      "message": "manifest invalid",
      "detail": {}
    }
  ]
}
```

I’ve also used a while loop to iterate over all layers which should make
sure that the order of the layers is correct. Previously `find` was
used and I’m not sure if the order was always correct.
    @lo1tuma @globin
    lo1tuma authored and globin committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    86d9b09 View commit details
    Browse the repository at this point in the history

  2. dockerTools: document image spec v1.2 compatibility

    @lo1tuma @globin
    lo1tuma authored and globin committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    cd3d852 View commit details
    Browse the repository at this point in the history