Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gwyddion: init at 2.48 #27896

Merged
merged 1 commit into from
Aug 11, 2017
Merged

Gwyddion: init at 2.48 #27896

merged 1 commit into from
Aug 11, 2017

Conversation

P-E-Meunier
Copy link
Contributor

Motivation for this change

Adding gwyddion, a tool to read images from several microscopy techniques.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member

I am confused, the PR is from a different person than the commit?!
Other than that, everything LGTM :D

@P-E-Meunier
Copy link
Contributor Author

That's because I have several github accounts, and github doesn't know who to attribute my commits to.

@globin globin merged commit 443ac23 into NixOS:master Aug 11, 2017
@P-E-Meunier P-E-Meunier deleted the gwyddion branch August 11, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@P-E-Meunier @NeQuissimus @globin