Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bashSnippets: 1.12.0 -> 1.17.3 #27888

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Conversation

infinisil
Copy link
Member

Motivation for this change

Updating the package. I also removed the mpv dependency, because it's kinda too big.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@kristoff3r
Copy link
Contributor

You should probably also delete mpv from the argument list (also netcat, which doesn't seem to be used?).

@infinisil
Copy link
Member Author

@kristoff3r Thanks, done

@globin globin merged commit 99be19c into NixOS:master Aug 4, 2017
@infinisil infinisil deleted the bashSnippets-update branch July 1, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants