Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nwjs 0.23 #27882

Merged
merged 1 commit into from Mar 19, 2018
Merged

Nwjs 0.23 #27882

merged 1 commit into from Mar 19, 2018

Conversation

Profpatsch
Copy link
Member

Motivation for this change

Remove the unmaintained old versions and update to the newest.

@matejc nixui was the only program depending on it, they seem to have changed their API

> result/bin/nixui 
[0803/022746.783454:WARNING:chrome_main_delegate.cc(569)] final extension: 
fs.js:953
  binding.stat(pathModule._makeLong(path));
          ^

Error: ENOENT: no such file or directory, stat '/etc/nixos/hardware-configuration.nix'
    at Object.fs.statSync (fs.js:953:11)
    at /nix/store/f2mc0v8fbrf3b23gq28j40j3d9fb184c-node-nixui-0.2.1/lib/node_modules/nixui/src/data.js:89:16
    at Array.forEach (<anonymous>)
    at HTMLElement.dbs.configurations (/nix/store/f2mc0v8fbrf3b23gq28j40j3d9fb184c-node-nixui-0.2.1/lib/node_modules/nixui/src/data.js:88:20)

I wouldn’t want to merge this until nixui is patched to work with 0.23.

@mention-bot
Copy link

@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @offlinehacker, @matejc and @bobvanderlinden to be potential reviewers.

@Profpatsch Profpatsch requested a review from matejc August 3, 2017 00:41
NeQuissimus
NeQuissimus previously requested changes Aug 5, 2017
View reviewed changes
pkgs/tools/package-management/nixui/default.nix Outdated
@@ -42,3 +42,4 @@ stdenv.mkDerivation rec {
platforms = stdenv.lib.platforms.unix;
};
}
/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this / should not be here :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, dunno how that sneaked in. Fixed.

@grahamc
Copy link
Member

grahamc commented Mar 19, 2018

@GrahamcOfBorg eval

@grahamc
Copy link
Member

grahamc commented Mar 19, 2018

@GrahamcOfBorg eval

@Profpatsch Profpatsch mentioned this pull request Mar 19, 2018
Open
@Profpatsch
Copy link
Member Author

Profpatsch commented Mar 19, 2018 •
edited

Okay, I’ve rebased this to the current master and changed it so we keep the outdated version nixui needs.

Meanwhile, nwjs already progressed to 0.29, but a version a little less ancient can’t hurt. :)

@Profpatsch Profpatsch force-pushed the nwjs-0.23 branch 2 times, most recently from 9643eb6 to f99bdf2 Compare March 19, 2018 04:31
@Profpatsch
Copy link
Member Author

@GrahamcOfBorg eval

@Profpatsch Profpatsch mentioned this pull request Mar 19, 2018
Closed
@Profpatsch
node_webkit/nwjs: 0.12 -> 0.23.6
f4df740 
Keep 0.12, because it is still needed by `nixui`.
Keep 0.9, because it is still needed by `zed`.
@Profpatsch Profpatsch merged commit 5e0cf58 into NixOS:master Mar 19, 2018
@grahamc
Copy link
Member

grahamc commented Mar 19, 2018

Just a note @Profpatsch, after you push to the branch an eval is automatically scheduled, so no need to call eval manually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus left review comments

@matejc matejc Awaiting requested review from matejc

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Profpatsch @mention-bot @grahamc @NeQuissimus @obadz @GrahamcOfBorg