Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classical Extras v 0.7 #109

Closed
wants to merge 116 commits into from
Closed

Classical Extras v 0.7 #109

wants to merge 116 commits into from

Conversation

MetaTunes
Copy link
Contributor

This plugin replaces the the previous (withdrawn) Classical Work Parts. It has been extensively reworked and enhanced.
It populates hidden variables in Picard with information from the MusicBrainz database about the recording, artists and work(s), and of any containing works, passing up through mutiple work-part levels until the top is reached.
The "Options" page (Options->Options->Plugins->Classical Extras) allows the user to determine how these hidden variables are written to file tags, as well as a variety of other options.
This plugin is particularly designed to assist with tagging of classical music so that player or library manager software which can display multiple work levels and different artist types can have access to them.

samj1912 and others added 30 commits April 9, 2017 01:50
Build plugin files for specific api versions
Adds multiple part levels for (particularly) classical music.
Version 0.1 for testing.
See readme for details.
Debug statements cleaned and other minor changes. Plugin is now called
classical_workparts rather than just workparts, to make intent clearer.
This version
- standardises all aoutput tags with prefix CWP_
- handles multiple works at lowest level only
- additionally outputs "extended metadata" tags combining MB database
and Title information
Fully documented with readme and scripts
Clarifies that this version does not work with m4a
samj1912 and others added 24 commits August 10, 2017 09:43
Adds multiple part levels for (particularly) classical music.
Version 0.1 for testing.
See readme for details.
Debug statements cleaned and other minor changes. Plugin is now called
classical_workparts rather than just workparts, to make intent clearer.

Version 0.3

This version
- standardises all aoutput tags with prefix CWP_
- handles multiple works at lowest level only
- additionally outputs "extended metadata" tags combining MB database
and Title information

Remove old workparts plugin - renamed Classical Work Parts

Minor corrections

Minor changes

Fully functional plugin
Fully documented with readme and scripts

Added jpg

ref to jpg

Updated readme

Clarifies that this version does not work with m4a

Final package for PR

Delete old version

Delete old version

Change tag to lower case

For all scripts other than "SongKong works", change tags to lower case

Merged classical plugins

Code tidy-up

Tagger scripts to run with Classical Extras plugin

Readme and more scripts

Minor amendments
Complete revision of classical extras plug-in incorportaing options page

Readme updates

Readme updates

Readme updates

Readme updates

Readme updates

Readme updates

Readme updates

Readme updates

Readme updates

Readme update

Readme update

Readme update

Code improvement

Add image

Readme update

Options and readme updates

Pic cropped

Readme updates

Readme update
Completed Readme plus some bug fixes

Bug fixes

Readme update

Readme update

Code tidy-up

Updated Readme

To include warning about cyrillic scripts

Allow non-Latin characters in works

Version 0.6.1 has amended regex to permit non-Latin characters in work
text.
Bug fixes. More flexible handling of artists (can blank and then add
back later). Modified ui default options.

Readme update

Bug fixes & Readme update
Write out version number to 'comment: classical_extras_version' tag.
Provide default comment tags for writing ui options. Provide better m4a
and iTunes compatibility (see readme). Added functionality for chorus
master, orchestrator and concert master (leader). Re-arranged artist tab
in ui. Various bug fixes.

Readme version correction

Tidy up

Readme update
Include ability to use multiple (concatenated) sources in tag mapping.
All artist "sources" using hidden variables (_cea_...) are now
consistently in the plural, to distinguish from standard tags. Note that
if "album" is used as a source in tag mapping, it will now be the
revised name, where composer prefixing is used. To use the original
name, use "release" as the source. Also various bug fixes, notably to
ensure that all arrangers get picked up for use in tag mapping.
Bug fixes and algorithm improvements. Allow multiple sources for a tag
(each will be appended) and use + as separator for concantenating
sources, not a comma, to distinguish from the use of comma to separate
multiples. Provide additional hidden variables ("sources") for vocalists
and instrumentalists. Option to include intermediate work levels in a
movement tag (for systems which cannot display multiple work levels).

Minor changes

Corrected defaults and readme
Bug fixes. Pull request issued for this version.

Version 0.7 bug fix

Version 0.7 bug fix - zip

Code improvements

Restructure folder

Code tidy

Code tidy

Strip whitespace

Fix Codacy issues

Remove binaries

Remove zip and jpgs. Update Readme. Also fix minor unicode issue with
tags.

Correct readme image links

Code tidy for PEP8 compliance
@MetaTunes
Copy link
Contributor Author

GitHub on Windows working again (suspect W10 prob as usual). I have attempted to rebase, but not sure if I've done it right. Please advise.

@zas
Copy link
Collaborator

zas commented Aug 10, 2017

Sorry, I'm still learning GitHub. I've been using GitHub desktop for Windows, but that doesn't seem to give an option to rebase and I can no longer load the master branch into it. So not sure where to go from here.

If you don't want to bother with git rebase, and don't mind to lose the history, you may just start over:

  • clone latest picard-plugins, branch 1.0 (which is the default)
  • copy classical_extras directory and its contents from the messy clone
  • make a new clean PR including ONLY the new files

BTW, the situation is even worser after your last pushes, it now contains twice the number of commits ;)

@MetaTunes
Copy link
Contributor Author

Looks like I rebased vs the wrong branch. Maybe re-clone etc would be best!

@MetaTunes
Copy link
Contributor Author

Looks like I rebased vs the wrong branch. Have issued new PR #110 to replace this one.

@samj1912 samj1912 closed this Aug 10, 2017
@MetaTunes
Copy link
Contributor Author

Closed this PR - replaced by #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants