Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve description of fonts #27895

Merged
merged 2 commits into from
Aug 3, 2017
Merged

improve description of fonts #27895

merged 2 commits into from
Aug 3, 2017

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 3, 2017

Motivation for this change

The old description is not very useful.

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@jtojnar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vbgl and @7c6f434c to be potential reviewers.

@jtojnar jtojnar changed the title junicode: make description more concrete improve description of fonts Aug 3, 2017
@FRidh FRidh merged commit f6817dd into NixOS:master Aug 3, 2017
@jtojnar jtojnar deleted the patch-1 branch August 3, 2017 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants