Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtstyleplugin-kvantum: init at 0.10.4 #27525

Closed
wants to merge 114 commits into from

Conversation

bugworm
Copy link
Contributor

@bugworm bugworm commented Jul 20, 2017

Motivation for this change

Wanted to add kvantum style engine

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bugworm
Copy link
Contributor Author

bugworm commented Jul 20, 2017

Whoops, I forgot to fix plugin path, one moment

bugworm and others added 28 commits July 20, 2017 20:49
1. Needs to call makeTest or else nothing happens when you run
   `nix-build nixos/tests/postgresql.nix`.

2. Tests run as root, so there needs to be a corresponding user in
   PostgreSQL.
I suspect these functions aren't widely used, but they are enabled in
PostgreSQL on Ubuntu and Arch.
…keyboard input

- Changed sha256 of src file, as this was apparantly changed on the
website

- Added missing libs: some X libs, alsa, dbus

- Changed patch to $out/houdini/Licensing.opt
localValidatorDir = ... was commented out in original file
so sed had no effect

- add export QT_XKB_CONFIG_ROOT
Without it only modifier keys worked, no text input
Rsync has its own patched compress function, and to be able to use the `-z` flag, it needs to use that one.

With `-zz` rsync can use an external zlib, but then it can't talk to older rsync versions.

More details at https://bugs.mageia.org/show_bug.cgi?id=13669
fpletz and others added 28 commits July 23, 2017 21:40
* network-manager-l2tp: don't run ./configure twice

* network-manager-l2tp: remove automake/autoconf
The previous package didn't build properly due to a bug in the build
script, and the nixos module didn't evaluate due to missing descriptions
in the options. This fixes both issues.

It also adds missing command-line options that weren't able to be set
and properly converts bools to the strings exhibitor expects.
Suggest prefixing commit messages that touches NixOS code with
"nixos/<module>" instead of the current "<name> service" prefix.

"<name> service" is limiting in that NixOS code is more than the
services. It is also easier to spot NixOS changes with explicit
"nixos/..." prefix.
I've tested the resulting build against the sample
"2013_04_04_GNSS_SIGNAL_at_CTTC_SPAIN" dataset linked from:

http://gnss-sdr.org/my-first-fix/

Many thanks to @knedlsepp for suggestions in NixOS#27505 that have
substantially improved this package!
Add option for archive support and fix dvdread and dvdnav support.
Also really use QT5 and switch download location to GitHub.
Or else nix-env updates the stable version to unstable.
starting with linux 4.12 our patch no longer applied. In order to
avoid having to maintain patches for different linux kernels it is
easier to use a wrapper instead.
(cherry picked from commit 0901dd50a2ed0d12b2bee8fdb147fdce5c1c5d69)
Signed-off-by: Domen Kožar <domen@dev.si>
@bugworm bugworm closed this Jul 23, 2017
@bugworm bugworm deleted the qtstyleplugin-kvantum branch July 23, 2017 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet