Skip to content

gitlab: fix archive urls for gitlab service #27507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jul 19, 2017

Motivation for this change

Accessing an url like https://gitlab.example.org/group/project/repository/archive.tar.gz?ref=master
requires tar/gzip to be in the path of the gitlab-workhorse service otherwise it fails.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Accessing an url like https://gitlab.example.org/group/project/repository/archive.tar.gz?ref=master
requires tar/gzip to be in the path of the gitlab-workhorse service otherwise it fails.
@LnL7 LnL7 added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jul 19, 2017
@fpletz fpletz merged commit 13b0b7d into NixOS:master Jul 19, 2017
@fpletz
Copy link
Member

fpletz commented Jul 19, 2017

Thanks!

@fpletz
Copy link
Member

fpletz commented Jul 19, 2017

Backported to 17.03: b798aa6

@LnL7
Copy link
Member Author

LnL7 commented Jul 19, 2017

Great, was just going to ask if I should back port it 😄

@LnL7 LnL7 deleted the fix-gitlab-archive-url branch July 19, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants