[NixOS] Fix + update `hardware.parallels` config option #27513

lukeadams · 2017-07-19T23:09:42Z

Motivation for this change

This PR enables support for Parallels 12, and also removes the need to provide prl-tools-lin.iso. It fixes dynamic resolution/coherence/clipboard support.

It may be a good idea to add:

hardware.parallels.version = {
    major = "12";
    minor = "2.1-41615";
    releaseSha256 = "1jwzwif69qlhmfky9kigjaxpxfj0lyrl1iyrpqy4iwqvajdgbbym";
};
# or
hardware.parallels.version = {
    full = "12.2.1-41615";
    major = lib.splitString "." full
    minor = lib.removePrefix major full
    releaseSha256 = "1jwzwif69qlhmfky9kigjaxpxfj0lyrl1iyrpqy4iwqvajdgbbym";
};

to allow the use of newer prl-tools versions in configuration.nix without forking nixpkgs

Squash before committing:
743485f6579422b1115986d40522d820b67b5b8f
041ae372c9531682118cdb5de99768a84fcc7a0c
c6700487d7d02453774c49bb42e2e25997a63999
I left them as separate commits for clarity

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

TODO: possibly add tests ala Virtualbox

mention-bot · 2017-07-19T23:09:44Z

@lukeadams, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @nckx and @fpletz to be potential reviewers.

lukeadams · 2017-07-25T19:55:42Z

@Mic92 this PR is for NixOS (in Parallels on Darwin)

lukeadams · 2017-07-26T18:35:20Z

Everything works once logged in. I couldn't find out how to create a systemd unit to launch prlcc in the getty "environment" (to allow dynamic resolution on the login window) though...

lukeadams · 2017-10-02T01:02:39Z

13.0.1-42947 (parallels 13 instead of 12) is now the latest. I haven't upgraded to it so have no idea if it works, but it should be easy to test by overriding with

prl_major = "13";
version = "${prl_major}.0.1-42947";

Mic92 · 2017-10-02T08:23:48Z

nixos/modules/virtualisation/parallels-guest.nix

+      description = "Parallels Control Center";
+      wantedBy = [ "graphical.target" ];
+      serviceConfig = {
+        ExecStart = "${prl-tools}/bin/prlcc";


I am not familiar at all with parallels to excuse my question:
What does prlcc that it is started both as a global service and a user in a graphical session?

I put prlcc as a "global" to try and get dynamic resolution working on the login screen; it can be removed. The user service is the important one which works perfectly once logged in.

I don't recall seeing prldhd in prl-12, but there was prldnd. I'm not sure if they have the same functionality?

Is there any recommendation by upstream? Running x11 applications as root can create security problems because their is not user separation in x11.

@Mic92 Fixed! I removed prlcc as a global service, and everything still works.

Mic92 · 2017-10-02T08:24:57Z

nixos/modules/virtualisation/parallels-guest.nix

+        description = "Parallels Control Center";
+        wantedBy = [ "graphical-session.target" ];
+        serviceConfig = {
+          ExecStart = "${prl-tools}/bin/prlcc";


I ask because there was a service called prldhd before.

Above comment:

I don't recall seeing prldhd in prl-12, but there was prldnd. I'm not sure if they have the same functionality?

I haven't looked at this in a while since I just needed it to work on my system at the time; if I have a chance this weekend I'll get more information for you.

Mic92 · 2017-10-02T18:34:10Z

cc @disassembler for review.

disassembler · 2017-10-03T01:49:12Z

I tested this PR in a parallels VM. It built successfully and auto-resizing worked in plasma/kde after login.

lukeadams · 2017-10-07T18:13:52Z

Above: prlcc as root has been removed.

I've rebased this PR onto channels/nixos-17.09 and everything works.

Additionally, diffing the directory structure from v12 (Parallels Tools)/v13(Parallels Tools 1) produces nearly identical output. The only differences are a few install scripts which we don't use!

Bitrig:Volumes lukeadams$ diff <( tree "Parallels Tools" ) <( tree "Parallels Tools 1" )
1c1
< Parallels\ Tools
---
> Parallels\ Tools\ 1
7d6
< │   ├── hname.sh
63a63
> │   ├── install-cli.sh
78c78,79
< │   ├── prlfsmountd.sh
---
> │   ├── prltimesync.fc
> │   ├── prltimesync.te
94a96,99
> │   ├── gnome-coherence
> │   │   ├── extension.js
> │   │   ├── metadata.json
> │   │   └── stylesheet.css
99a105
> │   ├── prlfsmountd.sh
131c137
< 30 directories, 98 files
---
> 31 directories, 103 files

…, fetchurl inputs; update sourceRoot

lukeadams · 2017-11-12T04:52:30Z

Rebased onto master for vm upgrade. Changes are still good

Mic92 · 2017-11-23T13:42:49Z

@GrahamcOfBorg eval

Mic92 added the 6.topic: darwin Running or building packages on Darwin label Jul 20, 2017

lukeadams force-pushed the prl-tools-fix branch 3 times, most recently from 71668c8 to 62c3ffa Compare July 26, 2017 18:32

FRidh requested review from copumpkin and LnL7 September 18, 2017 19:25

Mic92 reviewed Oct 2, 2017

View reviewed changes

Luke Adams added 9 commits November 11, 2017 17:05

prl-tools: ignore patchelf errors

1aef116

prl-tools: Update platforms and url

e58b67a

prl-tools: 10.0.2.27712 -> 12.2.1-41615; src: download parallels dmg

0b845ab

prl-tools: unpackPhase: extract prl-tools-lin.iso from dmg; add undmg…

019cbda

…, fetchurl inputs; update sourceRoot

prl-tools: hardeningDisable: +"format"

029b44d

prl-tools: remove unnecessary kernel modules

26d6eab

prl-tools: remove user services using .desktop files

6ead149

prl-tools: Add all user services using systemd.user

0f047e6

remove prlcc from global systemd services

2ce30c5

lukeadams force-pushed the prl-tools-fix branch from e872eb0 to 2ce30c5 Compare November 11, 2017 23:05

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 11, 2017

Mic92 merged commit 487c4a6 into NixOS:master Nov 23, 2017

lukeadams deleted the prl-tools-fix branch May 26, 2021 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NixOS] Fix + update `hardware.parallels` config option #27513

[NixOS] Fix + update `hardware.parallels` config option #27513

lukeadams commented Jul 19, 2017 •

edited

mention-bot commented Jul 19, 2017

lukeadams commented Jul 25, 2017

lukeadams commented Jul 26, 2017

lukeadams commented Oct 2, 2017

Mic92 Oct 2, 2017

lukeadams Oct 2, 2017 •

edited

Mic92 Oct 2, 2017

lukeadams Oct 7, 2017

Mic92 Oct 2, 2017

lukeadams Oct 2, 2017 •

edited

Mic92 commented Oct 2, 2017

disassembler commented Oct 3, 2017

lukeadams commented Oct 7, 2017 •

edited

lukeadams commented Nov 12, 2017

Mic92 commented Nov 23, 2017

[NixOS] Fix + update hardware.parallels config option #27513

[NixOS] Fix + update hardware.parallels config option #27513

Conversation

lukeadams commented Jul 19, 2017 • edited

Motivation for this change

Things done

mention-bot commented Jul 19, 2017

lukeadams commented Jul 25, 2017

lukeadams commented Jul 26, 2017

lukeadams commented Oct 2, 2017

Mic92 Oct 2, 2017

Choose a reason for hiding this comment

lukeadams Oct 2, 2017 • edited

Choose a reason for hiding this comment

Mic92 Oct 2, 2017

Choose a reason for hiding this comment

lukeadams Oct 7, 2017

Choose a reason for hiding this comment

Mic92 Oct 2, 2017

Choose a reason for hiding this comment

lukeadams Oct 2, 2017 • edited

Choose a reason for hiding this comment

Mic92 commented Oct 2, 2017

disassembler commented Oct 3, 2017

lukeadams commented Oct 7, 2017 • edited

lukeadams commented Nov 12, 2017

Mic92 commented Nov 23, 2017

[NixOS] Fix + update `hardware.parallels` config option #27513

[NixOS] Fix + update `hardware.parallels` config option #27513

lukeadams commented Jul 19, 2017 •

edited

lukeadams Oct 2, 2017 •

edited

lukeadams Oct 2, 2017 •

edited

lukeadams commented Oct 7, 2017 •

edited