Graphite #28297
Graphite #28297
Conversation
pkgs/top-level/python-packages.nix
Outdated
| }; | ||
|
|
||
| propagatedBuildInputs = with self; [ django django_tagging_0_3 whisper pycairo ldap memcached pytz ]; | ||
| propagatedBuildInputs = with self; [ django_1_8 (django_tagging.override { django = django_1_8; }) whisper pycairo ldap memcached pytz urllib3 cairocffi scandir pyparsing ]; |
There was a problem hiding this comment.
No overriding within the package set. All Django packages will need to depend just on django, and not on a specific version. If you application needs a specific version, then you need to override the whole Python package set when deploying it.
There was a problem hiding this comment.
When deploying it -> you mean in the service?
This means the 'stock' pythonPackages.graphite_web doesn't build, since it relies on Django 1.8. Is that expected? |
|
We are moving Python expressions out of Please move the expression there, and call it from |
|
@apeschar yes, that can be fine. |
|
This was already done in another pull request, so no longer relevant. |
Motivation for this change
django_tagging_0_3was only used by the older Graphite, so can be removed. (I suppose.)Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)