Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.locustio: use flask 0.10.1 instead of 0.12 which broke tests. #27712

Closed

Conversation

AmineChikhaoui
Copy link
Member

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@AmineChikhaoui, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

Nixpkgs is a curated set where we try to maintain only a single version of each package in order to prevent collisions between multiple versions in a closure. flask_assets is a relatively minor package (though a dependency of octoprint) so that doesn't warrant an extra version.

If flask_assets cannot handle the current version of flask, then they need to release a version that can. Until then, that could mean this package in Nixpkgs is broken.

@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

If the purpose was to fix octoprint, then within that closure the older flask could be used. Are you sure the older flask is absolutely needed? Is there an issue upstream?

@AmineChikhaoui
Copy link
Member Author

@FRidh the changed pkg is locustio. there is no changes to neither flask_assets/octoprint

@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

@AmineChikhaoui sorry, I misread the diff. Even so, its the same. We won't include an extra version of a package. What does upstream say regarding compatibility with 0.12?

@AmineChikhaoui
Copy link
Member Author

@FRidh so I think you're right it's probably better to fix it upstream as I tried git checkout v0.7.2; make test and reproduced the issue with Flask-0.12. I'll file an issue then.
But meanwhile should the pkg stay broken on 17.03 ?

@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

@AmineChikhaoui it must have been broken already on the release of 17.03 then, since we have flask 0.12 since then.

@AmineChikhaoui
Copy link
Member Author

opened locustio/locust#637

@FRidh
Copy link
Member

FRidh commented Jul 28, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants