fzf: add script for finding 'share' folder #27709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that helper scripts can be easily sourced in interactive shell configuration. `autojump` package was already present and had the same requirements for findind a `share` folders, so I took an inspiration there. I beleive this is a better alternative to: - NixOS#25080 - NixOS#27058 Replacing `$out/share/shell` with `$bin/share/fzf` was necessary to prevent dependency loop in produced derivations.
|
also documented here: https://github.com/nixos-users/wiki/wiki/fzf |
marsam
added a commit
to SebTM/nixpkgs
that referenced
this pull request
Apr 7, 2024
The fzf-share helper was added to help to find the shell scripts [1], but since fzf≥0.48.0 the it's no longer needed because fzf has its shell integration scripts embedded. [1] NixOS#27709
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
So that helper scripts can be easily sourced in interactive shell
configuration.
autojumppackage was already present and had the samerequirements for findind a
sharefolders, so I took an inspirationthere.
I beleive this is a better alternative to:
Replacing
$out/share/shellwith$bin/share/fzfwas necessary toprevent dependency loop in produced derivations.
Things done
Please check what applies. Note that these are not hard requirements but mereley serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)