Fix the download-prebuilt script. #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In theory, it will download the latest git revision in your branch which is upstream. Fixes timvideos#322.
mithro
force-pushed
the
download-prebuilt-fix
branch
from
c34ede9
to
f212ba8
Compare
|
@joeladdison You verified this worked, right? |
|
@mithro Yes, I did test it. The only issue is that It also relies on the latest commit having a successful build, but I'm not sure there is too much that can be done there apart from maybe tagging commits for successful builds and then using them. The script worked fine for me once the latest folder had the HDMI2USB firmware for the opsis. |
|
We should probably have a better error message. It's super frustrating that
GitHub doesn't support "git export"
…On 12 Aug. 2017 5:45 pm, "Joel Addison" ***@***.***> wrote:
@mithro <https://github.com/mithro> Yes, I did test it.
The only issue is that svn is now required, and it is not in the scripts
to setup an environment.
It also relies on the latest commit having a successful build, but I'm not
sure there is too much that can be done there apart from maybe tagging
commits for successful builds and then using them. The script worked fine
for me once the latest folder had the HDMI2USB firmware for the opsis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#340 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABS3KNnlfFPqzoTnpLT4SwLdRStRSMzks5sXVgLgaJpZM4OtRXm>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, it will download the latest git revision in your branch which
is upstream.
Fixes #322.