Fix emacs wrapper expression to honor bash array use #27921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
requested changes
Aug 4, 2017
pkgs/build-support/emacs/wrapper.nix
Outdated
| @@ -80,7 +80,7 @@ stdenv.mkDerivation { | |||
| linkPath "$1" "share/emacs/site-lisp" "share/emacs/site-lisp" | |||
| } | |||
|
|
|||
| for pkg in $requires; do | |||
| for pkg in "''${requires[@]}"; do | |||
There was a problem hiding this comment.
Please put a comment above describing what's going on.
There was a problem hiding this comment.
An excellent suggestion. Done!
In 8d76eff, @Ericson2314 changed the representation of the value that `findInputs` generated from a whitespace-separated bunch strings to an actual array of strings. Expressions that *consume* that value, however, also needed to be changed to iterate over all the contents of the array, else they would only select the first value, which turns out to be somewhat limiting. Fixes NixOS#27873
mdorman
force-pushed
the
emacs-wrapper-fix
branch
from
e10d51e
to
ef5ba4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8d76eff, @Ericson2314 changed the representation of the value that
findInputsgenerated from a whitespace-separated bunch strings to anactual array of strings.
Expressions that consume that value, however, also needed to be
changed to iterate over all the contents of the array, else they would
only select the first value, which turns out to be somewhat limiting.
Fixes #27873
Motivation for this change
Fix a bug!
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)