Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9c311feb3fcd
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 47d7e19a2ae1
Choose a head ref
  • 7 commits
  • 12 files changed
  • 1 contributor

Commits on Aug 3, 2017

  1. Copy the full SHA
    8eb7593 View commit details
  2. Copy the full SHA
    052eb10 View commit details
  3. Copy the full SHA
    8d3e2a8 View commit details
  4. Copy the full SHA
    f0177e4 View commit details

Commits on Aug 4, 2017

  1. Improve race potential in blockingThreads and tweak racy test.

    This race test in MRI's test_io can't be made to reliably raise
    only IOError in the threads for a few reasons:
    
    * The thread may not be at the gets call by the time the stream
      starts to be closed in the main thread, causing the gets to
      produce EBADF instead of IOError.
    * Even if we wait until the thread claims to be asleep, that
      state change is not atomic and so we may proceed to close the
      stream before the gets is actually blocking on it, again
      producing EBADF
    
    This small test tweak along with improvements to the blocking
    thread logic allows the test to pass.
    headius committed Aug 4, 2017
    Copy the full SHA
    dad9ab0 View commit details
  2. Copy the full SHA
    1925b5d View commit details
  3. Tag Random test that depends on Random::Formatter.

    We have Random::Formatter from securerandom.rb, but it appears
    MRI moved into core class Random at some point. Changes here need
    to make that move and incorporate other changes we have not kept
    up with.
    headius committed Aug 4, 2017
    Copy the full SHA
    47d7e19 View commit details
Loading