Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager service: use unbound if enabled #27925

Merged
merged 1 commit into from Aug 8, 2017
Merged

networkmanager service: use unbound if enabled #27925

merged 1 commit into from Aug 8, 2017

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Aug 4, 2017 •
edited

Motivation for this change

I want to be able to use unbound for dns together with networkmanager

Things done

Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@adisbladis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rickynils, @domenkozar and @nmikhailov to be potential reviewers.

@NeQuissimus
Copy link
Member

I know nothing about this, so I don't want to give you a "LGTM" :)
However, it does look fine from my POV. Maybe somebody else can review this.

@adisbladis
Copy link
Member Author

Here is the relevant networkmanager manpage segment on the subject: https://github.com/NetworkManager/NetworkManager/blob/a84facb90c8ed7214e2aeba1ce54909c00a82b2c/man/NetworkManager.conf.xml#L336

@adisbladis
Copy link
Member Author

@7c6f434c or @fpletz seem like suitable reviewers for this

@7c6f434c
Copy link
Member

7c6f434c commented Aug 8, 2017

Wait what? Have I ever touched NetworkManager?

On the other hand, this seems to be no-op for the default configuration and a sensible enough one-line-change, so maybe whatever.

@7c6f434c 7c6f434c merged commit 29c3ea0 into NixOS:master Aug 8, 2017
@adisbladis
Copy link
Member Author

@7c6f434c You were responsible for merging the last related PR #27143 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: enhancement 8.has: module (update) 9.needs: community feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adisbladis @mention-bot @NeQuissimus @7c6f434c